search

microsoft / ReportingServicesTools

Reporting Services Powershell Tools
MIT License
458 stars 213 forks source link

Fixed issue with Resolve-Path breaking UNC keypaths. #385

Closed Gavster4 closed 2 years ago

Gavster4 commented 2 years ago

Fixes https://github.com/microsoft/ReportingServicesTools/issues/384 .

Changes proposed in this pull request:

Changes Resolve-Path to examine the path as a Parent and Child instead of as a single unit to avoid damaging the proper UNC path. How to test this code: Restore-RSEncryptionKey -ReportServerInstance "Instance" -Password "Password" -KeyPath "\domain\share\folder\keyfile.snk" (Testing outside the module requires functions in ShouldProcess.ps1 and ConnectionObjectRequests.ps1)

Has been tested on (remove any that don't apply):

PSVersion 5.1.17763.2931 Windows Server 2019 Datacenter SQL Server 2016

Gavster4 commented 2 years ago

@jtarquino I think the appveyor build failed out during the execution of the setup functions and didn't get to the point of testing the change I made. I'm unsure if there is anything I need to do to proceed.