jtarquino
commented
1 year ago PR contributions are welcome, please also include a test to avoid regressions in the future by additional contributions
Closed danubie closed 1 year ago
jtarquino
commented
1 year ago PR contributions are welcome, please also include a test to avoid regressions in the future by additional contributions
Do you want to request a feature or report a bug?
A bug request.
What is the current behavior?
If a report is configured with a linked data source, updating the datasource of the report throws an error. Message is "Failed to update data sources for ... Invalid data source specified: @{...}"
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
A demo of that case is already documented in #383.
What is the expected behavior?
Updating a linked datasource of a report is possible. The cause is, that the property "IsReference" is not checked when checking datasource, connectionstring ... (lines180 ff)
Which versions of Powershell and which OS are affected by this issue? Did this work in previous versions of our scripts?
Both PS5.1 and PS7 show the same behaviour (not OS dependent). Due to the files history I would guess, that it failed ever since (e.g. see also #383).
Proposed fix
Add a check to $ds.IsReference when checking datasource, etc. I would like to provide a PR showing a test case and the fixed version - if you agree