microsoft / ReportingServicesTools

Reporting Services Powershell Tools
MIT License
458 stars 213 forks source link

SQL Server 2022 version 16 #409

Open luismcgITX opened 1 year ago

luismcgITX commented 1 year ago

Are these tools compatible with SQL Server 2022 version 16?

peter-mietlowski-igt commented 7 months ago

Not as-is but if you change the end of Libraries/library.ps1 from /// <summary> /// SQL Server vNext /// </summary> SQLServervNext = 15 to /// <summary> /// SQL Server vNext /// </summary> SQLServervNext = 16

or add another entry for SQL 2022 if you need this to manage 2016, 2019 (both seem to use 15) and 2022 which uses 16 it seems to work fine

mhallockPcty commented 7 months ago

Unfortunately Powershell does not allow you to patch in a new ENUM over the one they put in for Microsoft.ReportingServicesTools.SqlServerVersion, so we're SOL until a kind maintainer takes pity and updates here. See additional tickets here that haven't gotten traction either: https://github.com/microsoft/ReportingServicesTools/issues/394

For now, the only thing I can come up with is cloning a version of this repo down, adding the missing enum type, and installing the module from local instead of github / powershell package stores. Kinda sucks for automation purposes, but we haven't had much luck getting the change made here in almost a year...

mhallockPcty commented 7 months ago

Made a PR to try and get some attention from an MS dev, maybe we can get this fixed finally.

i8beef commented 7 months ago

They merged it! But looks like the build is outdated / needs fixed. @Petebro-MSFT mentioned taking a look at that, so hopefully we'll get a new version here soon!

mhallockPcty commented 7 months ago

@jtarquino any chance we can get 0.0.9.0 released to Powershell Gallery? It looks like the build usually did that in past successful ones, but we didn't get a good build through it yet even though its tagged appropriately to do so, etc.

jtarquino commented 7 months ago

@Petebro-MSFT is looking into it

i8beef commented 6 months ago

You guys have been great here getting this merged and everything, thank you for that!

I'm trying to be patient but I'm about to come against a wall with my needs here.... any chance we can get 0.0.9.0 uploaded to the package sources MANUALLY until we figure out the build? Otherwise I'm going to have to pull this entire repo into my own to be installed during an automated deploy (can't execute install.ps1 during said deploy if I source it from github directly, so I gotta embed if I have to do that).

Or any other options?

end-user commented 1 month ago

Also interested the next release (5 months later)...

mhallockPcty commented 1 month ago

I ended up just having to pull the repo contents directly, make the necessary bug fixes / modifications, and import in my scripts from local source instead of installing from online powershell package sources. It works, but obviously not ideal since I'm essentially managing a fork, but I don't think this project is officially supported by MS or something, so that's the best I could do.