microsoft / ReportingServicesTools

Reporting Services Powershell Tools
MIT License
458 stars 213 forks source link

Addresses #394, #409, adding SSRS 2022 vNext support to the SQLServer… #424

Closed mhallockPcty closed 7 months ago

mhallockPcty commented 7 months ago

…Version enum

Fixes #394 #409 .

Changes proposed in this pull request:

How to test this code:

Has been tested on (remove any that don't apply):

mhallockPcty commented 7 months ago

So, Im happy to attempt to blindly fix this... it looks like your build is downloading SQL Server 2017 files, and is hard coded to use SQLServervNext in all the build steps, which is gonna change as this is updated again and again... It looks like the last time you guys did this (https://github.com/microsoft/ReportingServicesTools/commit/478edd5e4532a13a5f7ded701344ac05ac67dc5a) this was just changing the version numbers on the downloads / temp / sql powershell module locations... I couldn't discern where you were downloading from to see if a SQLServer2022-x64-ENU.exe and SQLServer2022-x64-ENU.box existed at that location (thus the "blind attempt").

The PowerBI downloads throw me though, those don't look versioned and I have no experience with it to know if I can just update this or not. Please advise.

Also I believe 2017 is where you guys decoupled SSRS from SQL installs, so maybe that's why this hasn't been done yet? We'd need to rebuild your build pipeline to handle that split?

mhallockPcty commented 7 months ago

@microsoft-github-policy-service agree