search

microsoft / SCXcore

System Center Cross Platform Provider for Operations Manager
Microsoft Public License
36 stars 31 forks source link

Added tmpdir link for monitoring script storage/execution #31

Closed vimish closed 8 years ago

vimish commented 8 years ago

This is the SCXCore part of DCR to make monitoring script stored and executed from a custom location rather than hardcoded /tmp.

As part of the change a link /etc/opt/microsoft/scx/conf/tmpdir will be created during scx installation. It will point to /tmp by default. System admin can change this to point to any other location on the system.

When RunAs provider's ExecuteScript is called it will read the location and store the script there.

vimish commented 8 years ago

@Microsoft/ostc-devs

jeffaco commented 8 years ago

:-1:

I used CodeFlow for this, it actually worked really nicely! That was a recent change (just yesterday) that I made to OSTC-Docs.

You do NOT have signoff here, I'd like to see another iteration please. Thanks.

vimish commented 8 years ago

@Microsoft/ostc-devs

Please review the next iteration of the fix. Major changes are: 1) Default temporary directory is set in PAL when run as provider is loaded. Same location is retrieved from PAL and used during ExecuteScript call. 2) Unit test has been modified to set tmpDir location to testrunner location.

vimish commented 8 years ago

Pbuild has been run on all the dev systems and it was clean.

jeffaco commented 8 years ago

:-1:

I'd like to see another iteration on this please. Be sure that you only have one commit message.

Thanks.

jeffaco commented 8 years ago

Are you planning on posting another iteration on this? My last comments (asking for another iteration) was over a week ago.

Thanks!

vimish commented 8 years ago

Please review the next iteration of the fix. Major changes are: 1) Logic to store tmp directory location has been moved from systeminfo to RunAsProvider. 2) More testcase has been added for tmpDir functionality of ExecuteScript Method.

vimish commented 8 years ago

Pbuild has been run on all the dev systems and it was clean.

jeffaco commented 8 years ago

With my suggested changes above, I sign off. If you have any questions on my suggestions, feel free to reach out.

Please run a PBUILD prior to checkin to make sure everything works as expected ...

vimish commented 8 years ago

Merged #31