search

microsoft / SCXcore

System Center Cross Platform Provider for Operations Manager
Microsoft Public License
36 stars 31 forks source link

Fix non default config in JBoss 7 #56

Closed vimish closed 7 years ago

vimish commented 7 years ago

@Microsoft/ostc-devs

For standalone mode JBoss 7 allows use of some non default config file (standalone-full.xml, standalone-ha.xml etc) . Our current code only considers default stanalone.xml file. Hence when JBoss starts with non default config file it was getting wrongly interpreted as Jboss 4, 5 or 6 which resulted in wrong install path for that JBoss instance.

jeffaco commented 7 years ago

@agup006 I know it's not your job, but it might be useful if you took a gander at this code change. I don't understand enough about JBoss to understand the ramifications of this change,

agup006 commented 7 years ago

@vimish this looks good

  1. Does this work If a user uses the command line for ports, or bind-address?
  2. Is there a way to make this applicable to domain mode configurations as well?
vimish commented 7 years ago

@agup006

  1. No. It seems current implementation only supports reading ports from config file for JBoss7 and above. Current fix only enables user to use a different config file and the ports will be read from the passed config. If command line support is required I can add it in another fix.
  2. The customer reported the issue only in standalone mode. I will find out if any similar option is present for domain mode configuration.