microsoft / SDN

This repo includes PowerShell scripts and VMM service templates for setting up the Microsoft Software Defined Networking (SDN) Stack using Windows Server 2016
Other
486 stars 541 forks source link

VMM SDN Express: Logging broken #182

Open jrp2014 opened 6 years ago

jrp2014 commented 6 years ago

The VMM Express script LogWrite function

Function LogWrite
{
   Param (
        [string] $logstring
    )

    write-verbose $logstring
    Add-content $Logfile -value $logstring
}

takes a string argument, but in several places there are calls such as

LogWrite "COnnection String :" $ConnectionString

Apart from the typos, the second argument ($ConnectionString in this case) is ignored.

jrp2014 commented 6 years ago

To follow up to my own message, having tried to work with VMM SDN Express a bit further, it would save a great deal of angst if it had a bit more checking / environmental validation. Part of the problem is (partly understandable) SCVMM state latency. For example, the VMMExpress script gets as far as creating an NC, but then can't reach it, for reasons unspecified. Rebooting the host VM cluster and retrying leads to a more intelligible message (that the NC requires a non-isolated network). Why does the script not check first? It would be slightly less troublesome if the original error message from SCVMM was helpful, but it isn't. Similarly, for uplink ports, net switch extensions, etc.

All this slightly gives the impression that this script was written for a specific demo, rather than as a professional tool.

ChristineBoersen commented 4 years ago

Agreed would have saved me many hours trying to implement over a preexisting network (like many SMB do) if the scripts

Also if there was a way to offline the changes fopr some of these settings versus having to recreate