microsoft / SPID-and-Digital-Identity-Enabler

This repo contains the SPIDProxy code and several ADFS/Azure B2C related scripts and assets. SPIDProxy allows to communicate with SPID, CIE and eIDAS. The repo also contains a web app enabling CNS authentication through ADFS and AAD B2C.
MIT License
27 stars 12 forks source link

samlp:Extensions should be placed after Issuer tag #36

Closed fume closed 2 years ago

fume commented 2 years ago

SAMLRequest schema dictates to have the Extensions tag right after the Signature, hence we must add it after the Issuer tag.

The code to change is here: https://github.com/microsoft/SPID-and-Digital-Identity-Enabler/blob/ada2d5fc94686d23e882f0bc443ae8a534d45ce3/WebApps/Proxy/Microsoft.SPID.Proxy/Models/Extensions/RequestSAMLAsXMLExtensions.cs#L175

Instead of appending the Extensions to rootEl, we should InsertAfter the Issuer tag, which we should retrieve.