microsoft / SQLServerPSModule

This repo is the home of SQL Server PowerShell Module development.
MIT License
45 stars 1 forks source link

Write-SqlTableData doesn't clear Write-Progress bar #75

Closed samplesty closed 3 hours ago

samplesty commented 4 months ago

Writing data to a table with Write-SqlTableData creates permanent Write-Progress bars that never clear. There is likely a missing call to Write-Progress with the -Complete flag in order to close out the bar. Also the bar never seems to fill to 100% despite the text status reporting 100%.

Matteo-T commented 4 months ago

hi @samplesty - I'll try to take a look as soon as I have a chance.

Matteo-T commented 4 days ago

Hi @samplesty,

It's indeed a bug (or two). Thanks for reporting it.

Now, it looks a lot better:

This is what I get (after the fix) in PS5.1: image

This is what I get (after the fix) in PS7 (7.4.3): image

If all goes well, this fix should roll into the upcoming v22.3.x version of the module.

Matteo-T commented 3 hours ago

Fixed in v22.3.0 - or at least improved. Let me know what you think...