search

microsoft / STL

MSVC's implementation of the C++ Standard Library.
Other
9.88k stars 1.45k forks source link

Update _MSVC_STL_UPDATE to June 2024 in yvals_core.h #4708

Closed Arup-Chauhan closed 1 week ago

Arup-Chauhan commented 3 weeks ago

Fixes #4704

This pull request updates the _MSVC_STL_UPDATE macro value in yvals_core.h to the latest version. This change is intended to reflect the current state of the STL.

Arup-Chauhan commented 3 weeks ago

Hi, as per the requirements of the contributing to STL open source, I have made a PR request, please approve.

jovibor commented 3 weeks ago

It intersects with already opened #4706.

Arup-Chauhan commented 3 weeks ago

It intersects with already opened #4706.

Hi I wanted to follow the "good-first-issue" methodology as mentioned by Stephan and contribute to STL open source and hence raised this PR.

Please guide me is there any other alternative, to avoid this intersection?

jovibor commented 3 weeks ago

I mean your PR is a duplicate of the #4706 that was opened a bit earlier.

Arup-Chauhan commented 3 weeks ago

I mean your PR is a duplicate of the #4706 that was opened a bit earlier.

Yes, I did notice it, what should be my next steps?

StephanTLavavej commented 3 weeks ago

Thanks! We merge PRs simultaneously to the GitHub and MSVC-internal repos in a semi-manual process, batched up to save time. As #4706 was created earlier, but wasn't initially linked to the issue it resolves, I believe you both deserve credit. I'll merge the earlier-created PR, but credit you as a co-author. I'll post a comment here when that happens.

Arup-Chauhan commented 3 weeks ago

Thanks! We merge PRs simultaneously to the GitHub and MSVC-internal repos in a semi-manual process, batched up to save time. As #4706 was created earlier, but wasn't initially linked to the issue it resolves, I believe you both deserve credit. I'll merge the earlier-created PR, but credit you as a co-author. I'll post a comment here when that happens.

Thank you @StephanTLavavej ! Looking forward for more contributions!

StephanTLavavej commented 1 week ago

I've merged the earlier-created PR and credited you as a co-author for this identical change:

https://github.com/microsoft/STL/commit/065a036b765bd56301f6e57075a2fb14b945340f

I'll also link your PR in the STL Changelog. Thanks again and congratulations on your first STL commit! :tada: :smile_cat: :partying_face: