search

microsoft / STL

MSVC's implementation of the C++ Standard Library.
Other
9.88k stars 1.45k forks source link

Unskip sized deallocation tests with clang #4710

Open h-vetinari opened 3 weeks ago

h-vetinari commented 3 weeks ago

I saw the following https://github.com/microsoft/STL/blob/e36ee6c2b9bc6f5b1f70776c18cf5d3a93a69798/tests/libcxx/expected_results.txt#L360-L365

This must have narrowly missed the update in #4702, because clang now finally supports (since https://github.com/llvm/llvm-project/commit/130e93cc26ca9d3ac50ec5a92e3109577ca2e702) sized allocation by default, see also here.

frederick-vs-ja commented 3 weeks ago

I'd like to add -fsized-deallocation at this moment and say TRANSITION, Clang 19, LLVM-90373.

StephanTLavavej commented 2 weeks ago

FYI, my PR #4713 updates LLVM sufficiently to pick up that commit.