Closed frederick-vs-ja closed 1 day ago
~Remaining test failures seem related to #4320. Perhaps I also need to fix it.~
Edit: nope, they're unrelated. The locale-related test cases should be conditionally skipped.
There are a lot of code movements. To make code review easier, can you split them into a separate commit?
There are a lot of code movements. To make code review easier, can you split them into a separate commit?
Done.
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.
Thanks for this next step towards completing C++23! :tada: :heart_eyes_cat: :green_heart:
Towards #2919/WG21-P2286R8/WG21-P2585R1.
The following tests are derived from libc++'s test files:
P2286R8_text_formatting_range_map
P2286R8_text_formatting_range_sequence
P2286R8_text_formatting_range_set
P2286R8_text_formatting_range_string
Note that libc++'s
range_formatter
is currently buggy on them
option, see LLVM-90196 and LLVM-94562.The test
P2286R8_text_formatting_tuple_disambiguation
covers formattingpair
s andtuple
s that are also ranges.Unblocks libcxx tests:
std/containers/sequences/vector.bool/vector.bool.fmt/format.functions.format.pass.cpp
std/containers/sequences/vector.bool/vector.bool.fmt/format.functions.vformat.pass.cpp
std/utilities/format/format.range/format.range.fmtdef/parse.pass.cpp
std/utilities/format/format.range/format.range.fmtmap/format.functions.format.pass.cpp
std/utilities/format/format.range/format.range.fmtmap/format.functions.vformat.pass.cpp
std/utilities/format/format.range/format.range.fmtmap/parse.pass.cpp
std/utilities/format/format.range/format.range.fmtset/parse.pass.cpp
std/utilities/format/format.range/format.range.fmtstr/format.functions.format.pass.cpp
std/utilities/format/format.range/format.range.fmtstr/format.functions.vformat.pass.cpp
std/utilities/format/format.range/format.range.fmtstr/parse.pass.cpp
std/input.output/iostream.format/print.fun/includes.compile.pass.cpp