microsoft / SizeBench

SizeBench is a binary size investigation tool for Windows
MIT License
103 stars 14 forks source link

Column sorting should be done using stable sort implementation #11

Open horenmar opened 2 years ago

horenmar commented 2 years ago

Describe the bug I cannot compose column sorting in SizeBench, because it uses unstable sorting for sorting by column.

What you are doing 1) Open a binary for inspection 2) Select "Start Exploring By Compilands" 3) Sort results by specific column, e.g. Size on Disk 4) Sort results by different column, e.g. Lib Name

Expected behavior I want the rows to be sorted by Lib Name and within single lib, by their size on disk.

What actually happens is that I get rows sorted by Lib Name and otherwise jumbled, so I can't go after largest obj files in given lib, which is what I want to do.

Environment Details

Additional context While my original use case is specifically grouping by lib, sort by size on disk, using stable sort when sorting by column will allow users to compose their own sorting orders arbitrarily.