With the latest Visual Studio 2022 and .NET 8 SDKs, some Roslyn rules went from nothing to suggestion, and because SizeBench cranks most things up to error, this causes build errors. So this gets us back to a clean build on the latest SDK.
Briefly summarize what changed
There's two fixes:
If it's a trivial fix, just fix it (e.g. functions that should be static because they don't touch instance data)
Why is this change being made?
With the latest Visual Studio 2022 and .NET 8 SDKs, some Roslyn rules went from nothing to suggestion, and because SizeBench cranks most things up to error, this causes build errors. So this gets us back to a clean build on the latest SDK.
Briefly summarize what changed
There's two fixes:
How was the change tested?
The build is the main test, but of course all existing tests also pass.
PR Checklist