microsoft / SizeBench

SizeBench is a binary size investigation tool for Windows
MIT License
103 stars 14 forks source link

Some binaries fail to open due to multiple Compiland SymIndexIDs mapping to one Compiland object, and also a small About Box fix for the GUI #37

Closed Austin-Lamb closed 7 months ago

Austin-Lamb commented 7 months ago

Why is this change being made?

A customer reported that their binary could not be opened in SizeBench.

Briefly summarize what changed

Multiple SymIndexID values from DIA can map to the same SizeBench Compiland object (such as the null string and empty string). So, much like I did with source files recently, change Compiland entities to hold multiple SymIndexIDs and make the 1:many relationship work in all the places it needs to.

While I was in here it is convenient to also fix #36 where the About Box had a bad link in it since it's so trivial, so I did that.

Fixes #36

How was the change tested?

Manually with the customer's binary. And ran all the existing tests.

PR Checklist