Some minor tweaks - Githubissues

microsoft / Spartan

Spartan: High-speed zkSNARKs without trusted setup

MIT License

690 stars 121 forks source link

Some minor tweaks #21

Closed dlubarov closed 4 years ago

dlubarov commented 4 years ago

A few other questions/comments:

Is the PC scheme Hydrax-PC? I think it would be good to mention it explicitly.
Have you thought about using VartimeEdwardsPrecomputation for commitments? I think most users would be happy with that tradeoff (faster proofs, slower precomputation, a bit more memory), though maybe not 100%.

ghost commented 4 years ago

All CLA requirements met.

srinathsetty commented 4 years ago

To answer your questions:

Is the PC scheme Hydrax-PC? I think it would be good to mention it explicitly.

Yes, I'll add it to README.md

Have you thought about using VartimeEdwardsPrecomputation for commitments? I think most users would be happy with that > tradeoff (faster proofs, slower precomputation, a bit more memory), though maybe not 100%.

I did try this. But, I didn't notice any improvement in proof generation times. Maybe I can push what I did on a separate branch?

hdevalence commented 4 years ago

One thing to note is that VartimeEdwardsPrecomputation trades space for time pretty aggressively, but for very large multiscalar multiplications the precomputation may be too large to help much.

srinathsetty commented 4 years ago

Yes, thanks @hdevalence! I had forgotten about this from our email exchange a few months ago.