Cleaner Error handling + Refactor to idiomatic Result/Option patterns

microsoft / Spartan

Spartan: High-speed zkSNARKs without trusted setup

MIT License

672 stars 112 forks source link

Closed huitseeker closed 3 years ago

huitseeker commented 4 years ago

This:

introduces a small thiserror-powered enum to improve ProofVerifyError's messages,
refactors point decompression errors into a variant of that enum, thereby suppressing the panics which occur when decompresison fails.
folds other panics into the Error cases of their enclosing Result return

ghost commented 4 years ago

All CLA requirements met.

srinathsetty commented 4 years ago

Thanks for the PR! This looks good!

@huitseeker could you please sign the CLA so it can be merged?

srinathsetty commented 4 years ago

Thanks for the PR! This looks good!

@huitseeker could you please sign the CLA so it can be merged?

@huitseeker, any update on this?

huitseeker commented 3 years ago

@srinathsetty Thanks for your patience, I've now cleared the legal setup phase!

srinathsetty commented 3 years ago

@huitseeker I'm glad to hear! Thanks again for the PR, it is now merged!