microsoft / Spartan

Spartan: High-speed zkSNARKs without trusted setup
MIT License
691 stars 121 forks source link

Possible Mistake in Assert Statement #70

Closed ishwarbb closed 1 month ago

ishwarbb commented 6 months ago

src/sparse_mlpoly.rs - line 1265 has the following code -

assert_eq!(eval_dotp_left.len(), eval_dotp_left.len());

Was this the intended behavior? Did the authors mean this instead -

assert_eq!(eval_dotp_left.len(), eval_dotp_right.len());
srinathsetty commented 6 months ago

Thanks for the catch! Yes, indeed the assert is what you noted in the last line. It is not critical for correctness, but it should be fixed.