search

microsoft / SqlNexus

SQL Nexus is a tool that helps you identify the root cause of SQL Server performance issues. It loads and analyzes performance data collected by SQL LogScout, SQLDiag or PSSDiag. It can dramatically reduce the amount of time you spend manually analyzing data.
MIT License
356 stars 101 forks source link

Issue #176 cal license notification #177

Closed jagriffin5 closed 2 years ago

jagriffin5 commented 2 years ago

Add check to Analysis Summary for CAL licenses usage and when the number of schedulers are less than the number of CPUs. This is an info warning and would still require engineer to validate but brings light to the low scheduler use along with the CAL license which restricts to 20 physical or 40 logical cores.

PiJoCoder commented 2 years ago

@jagriffin5 I see you have created a PR. Are you ready for us to review or are you still working on it? I also just made a suggestion for a change

jagriffin5 commented 2 years ago

Yes, it is good to go. I noticed the comments and approved/committed those suggestions. Thank you for that.

PiJoCoder commented 2 years ago

Yes, it is good to go. I noticed the comments and approved/committed those suggestions. Thank you for that.

Great! I will test and review within the next 2-3 days and merge if all looks good.