search

microsoft / SqlNexus

SQL Nexus is a tool that helps you identify the root cause of SQL Server performance issues. It loads and analyzes performance data collected by SQL LogScout, SQLDiag or PSSDiag. It can dramatically reduce the amount of time you spend manually analyzing data.
MIT License
348 stars 99 forks source link

Fixing the PowerBI Performance Report #242

Closed asavioliMSFT closed 1 year ago

asavioliMSFT commented 1 year ago

Changed a script that was having issues when collecting perfmon data from FCI instances. To get the machine name and find the counter, instead of using SERVERPROPERTY('ComputerNamePhysicalNetBIOS'), it was using SERVERPROPERTY('MachineName'), which returns the SQL virtual name. The perfmon counters have the physical machine name always, even if this is a FCI.

Also changed a script that was causing issues when the instance where the nexus database is created doesn't have the collation SQL_Latin1_General_CP1_CI_AS. Now it should work with any collation

How to test:

1 - Perfmon data issue with FCI instances

2 - Collation Issue

In case you have a nexus database created on a SQL instance that doesn't have the collation SQL_Latin1_General_CP1_CI_AS, run the PowerBI Performance Report against it. In the current version, it will fail with a conflict collation error when running the DatabaseFiles report. With this version, it should work with any instance collation

PiJoCoder commented 1 year ago

Tested this and indeed all the Perfmon reports are loading successfully! Great work. Thank you