Fix #232 (report appears if all tables are there) #247 (fix working set trimming report) and #243 (add CCC rule) - Githubissues

microsoft / SqlNexus

SQL Nexus is a tool that helps you identify the root cause of SQL Server performance issues. It loads and analyzes performance data collected by SQL LogScout, SQLDiag or PSSDiag. It can dramatically reduce the amount of time you spend manually analyzing data.

MIT License

348 stars 99 forks source link

Fix #232 (report appears if all tables are there) #247 (fix working set trimming report) and #243 (add CCC rule) #252

Closed hacitandogan closed 12 months ago

hacitandogan commented 1 year ago

worked on the issue #232 Although this should prevent those errors , for future maybe we should consider some of our reports to handle these kind of situations.(Especially when the partial information is still meaningfull even if you have some data missing )

PiJoCoder commented 12 months ago

@hacitandogan thank you for all this work. Just saw this today. I'll be testing and providing feedback. Thank you

PiJoCoder commented 12 months ago

@hacitandogan thank you

Tested working set trimming report - looks good
Tested multiple tables report - tempdb space usage - looks good
For usp_CCC_Enabled, add an "EXEC usp_CCC_Enabled" at the bottom of PerfStatsAnalysis.sql to activate the rule
Could you undo the changes to NexusReports/NexusReports.rptproj.rsuser it gets automatically modified every time you make a report change and I personally reverse the change to it as this change is not relevant. There may be a way to disable changing the user's property here, but I have investigated. For now, just dicard the change to this file and push
Can you do a git pull upstream master since we merged a PR today and the Master is updated and push

hacitandogan commented 12 months ago

@PiJoCoder Thank you. I did the modifications and tried to revert .rsuser file to its original yet it still looks like a commit , could you please review and comment ?

PiJoCoder commented 12 months ago

@PiJoCoder Thank you. I did the modifications and tried to revert .rsuser file to its original yet it still looks like a commit , could you please review and comment ?

Looks like it worked. I don't see the file listed as one of the changed ones:

PiJoCoder commented 12 months ago

Tested Common criteria compliance rule - looks good

PiJoCoder commented 12 months ago

Thank you @hacitandogan - great work on these!