search

microsoft / SqlNexus

SQL Nexus is a tool that helps you identify the root cause of SQL Server performance issues. It loads and analyzes performance data collected by SQL LogScout, SQLDiag or PSSDiag. It can dramatically reduce the amount of time you spend manually analyzing data.
MIT License
348 stars 99 forks source link

Some Importer options aren't "saved" despite "Save my options" being enabled #254

Closed PiJoCoder closed 11 months ago

PiJoCoder commented 12 months ago

For example Enabled -T35 under ReadTrace Importer is not saved permanently. Has to be toggled off and then back on Same for newly added options for BLG cmd window to be minimized and -B for local server time for ReadTrace

PiJoCoder commented 11 months ago

Look around

  private static void Save()
        {
            Properties.Settings.Default.ImporterOptions = m_options.ToString();
            Properties.Settings.Default.Save();
        }
PiJoCoder commented 11 months ago

The issue was that the saved options weren't re-refreshed or re-considered after a single import is complete. We have to re-read their values from the user.config file back into memory and apply them in the ToolStripMenuItem