search

microsoft / SqlNexus

SQL Nexus is a tool that helps you identify the root cause of SQL Server performance issues. It loads and analyzes performance data collected by SQL LogScout, SQLDiag or PSSDiag. It can dramatically reduce the amount of time you spend manually analyzing data.
MIT License
356 stars 100 forks source link

Name property is not defined for multiple controls in the header section. #343

Closed JamesFerebee closed 3 weeks ago

JamesFerebee commented 5 months ago

Same issue replicates for similar controls throughout the application.

Impact on a Person with Disability (PWD): Screen Readers users are getting impacted and will not understand the context of given control as name Property is not defined for multiple elements.

Test Environment:​

OS: Windows 11 [Version 22H2 (OS Build 22621.2283)].

Desktop application: SQL Nexus.

Tool: Narrator, JAWS (2022.2110.6).

Prerequisite:

  1. Install SQLNexus application in the desktop.
  2. Turn on Accessibility Insights for windows.
  3. Enable Narrator/JAWS.

Repro Steps: Step 1: Open the SQL Nexus app on the desktop. Step 2: Connect to server Dialog gets displayed. Connect to the server by invoking connect button. Step 3: Navigate to SQL Perf Main and invoke it. Step 4: Navigate to Best practices & Analysis summary and invoke it. Step 5: Run accessibility insights for Windows tool and Verify whether the Name property is not defined for multiple controls in the header section or not

Actual Result: Name property is not defined for multiple controls in the header section.

  1. 100 % combo box
  2. Find edit field.
  3. Current DB combo box Screen reader behavior:
  4. Narrator is announcing as '100% combo box collapsed'.
  5. Narrator is announcing as 'Edit'.
  6. Narrator is announcing as 'SQLNexus combo edit collapsed SQLNexus selected'.

Expected Result: Name property should be defined for above mentioned controls in the header section. Ex Screen reader behavior:

  1. Narrator should be announcing as 'zoom 100% combo box collapsed'.
  2. Narrator should be announcing as 'Find Edit field'.
  3. Narrator should be announcing as 'Current DB SQLNexus combo edit collapsed SQLNexus selected'.

Suggestive Fixes: Provide "aria-label" attribute with required name to the elements.

JamesFerebee commented 5 months ago

1711725

PiJoCoder commented 3 weeks ago

Fixed by PR https://github.com/microsoft/SqlNexus/pull/365