fix OPENROWSET with numeric codepage as string

microsoft / SqlScriptDOM

ScriptDOM/SqlDOM is a .NET library for parsing T-SQL statements and interacting with its abstract syntax tree

MIT License

135 stars 18 forks source link

fix OPENROWSET with numeric codepage as string #69

Closed lBilali closed 7 months ago

lBilali commented 8 months ago

This pull request fixes #63

since when codepage is a number no check is done if the value is a valid codepage this change does the same when the code page is a number as string

lBilali commented 8 months ago

@microsoft-github-policy-service agree

jashwood commented 3 months ago

I'm still getting this in the latest version of VS. The OPENROWSET documentation clearly has single quotes around the value expected, making it look like it should expect a string

dzsquared commented 3 months ago

You're right @jashwood, I'm also seeing an old version of scriptdom in VS. Checking with the team if the update can be picked into the next preview release.