search

microsoft / StigRepo

Automated PowerSTIG Repository for Active Directory environments
35 stars 6 forks source link

New-SystemData localhost parameter not generating system data properly #13

Closed wwellington2 closed 3 years ago

wwellington2 commented 3 years ago

Bug/Issue Description Provide a clear and concise description the bug/issue

Reproduction Steps Steps to reproduce the behavior:

  1. New-SystemData -localhost on a Server will generate system data with PowerSTIG_WindowsClient as an applied config. (Win10 settings are applied)

Expected Behavior A clear and concise description of what you expected to happen

  1. New-SystemData -localhost on a Server should generate system data that is server related.

Recommended fix action If applicable, provide recommendations for how the bug/issue should be remediated

TBD

Existing Workarounds If applicable, provide any existing workarounds for the bug/issue

Screenshots

  1. localhost

Additional context Add any other context about the problem here.

coaldric commented 3 years ago

New-SystemData/ActiveDirectoryFunctions - Issue: If using the paramter -scope and value "local", it will generate data for Windows 10 regardless of what the localhost OS is. This is because in lines 115-124, the values are staticaly/explicitly set to "OperatingSystem = "Windows 10"" instead of dynamically generating that data. @JakeDean3631

JakeDean3631 commented 3 years ago

Issue closed in version 1.4