search

microsoft / TemplateStudio

Template Studio accelerates the creation of new WinUI 3, WPF, and UWP apps using a wizard-based experience.
Other
2.68k stars 457 forks source link

Deeplinking sample page is not showing title correctly on NavigationView Projects #2528

Closed sibille closed 5 years ago

sibille commented 6 years ago

Repro Steps:

  1. Create an app with project type Navigation View and add DeepLinking feature
  2. Run the app to register protocolname
  3. Close the app
  4. Activate the app using URI "wtsapp:sample?secret=test" from Windows->Run

Actual result: AppName.ViewModels.ShellViewModel is showing instead of title, similiar to this capture: sample

This behaviour is due to the fact that the page is not added to the NavigationViewItems, and Header is bound to the selected item.

The title would show correctly if we added the Sample page to the NavigationViewItems, but as it is a sample page that's not really part of the project we're not sure about it. Another option would be adding an empty string as fallbackvalue to the header, to show a blank header instead of AppName.ViewModels.ShellViewModel.

@crutkas, @mrlacey whats your opinion?

sibille commented 6 years ago

Thinking about this, I believe we should add this page to the NavView to provide a complete and consistent example. We can add a text similar to this one to provide extra guidance when user navigates to the page using the NavView

image

sibille commented 6 years ago

We'll have a look at activation from DeepLinking to Pivot Projects too. App activates on SamplePage directly, instead of showing the SamplePage in the Pivot. X-Ref: #2540

sibille commented 5 years ago

Verified in dev-nightly: Templates version: 0.18.18257.1 Wizard version: 0.18.18257.1