search

microsoft / TemplateStudio

Template Studio accelerates the creation of new WinUI 3, WPF, and UWP apps using a wizard-based experience.
Other
2.68k stars 457 forks source link

Add MenuBar project type templates for VB #2999

Closed sibille closed 5 years ago

sibille commented 5 years ago

Add MenuBar project type templates for VB (X-Ref #2292)

sibille commented 5 years ago

@mrlacey, I just ran the .\Synchronize-Files-Used-By-VisualBasic-Templates.ps1 against dev for the 3.1 release and got the following errors:

Cannot find path 'C:\Projects\WindowsTemplateStudio\templates\Uwp\_composition\CodeBehind\Feature.DeepLinking_Blank\Strings\en-us\Resources_postaction.resw' because it does not exist.
Cannot find path 'C:\Projects\WindowsTemplateStudio\templates\Uwp\_composition\CodeBehind\Feature.DeepLinking_Blank\Views\SchemeActivationSamplePage_postaction.xaml' because it does not exist.
Cannot find path 'C:\Projects\WindowsTemplateStudio\templates\Uwp\_composition\CodeBehind\Feature.DeepLinking_Blank\Views\SchemeActivationSamplePage_searchreplace.xaml' because it does not exist.
Cannot find path 'C:\Projects\WindowsTemplateStudio\templates\Uwp\_composition\CodeBehind\Page.ContentGrid.Blank\Views\wts.ItemNameDetailPage_postaction.xaml' because it does not exist.
Cannot find path 'C:\Projects\WindowsTemplateStudio\templates\Uwp\_composition\CodeBehind\Page.ImageGallery.Blank\Views\wts.ItemNameDetailPage_postaction.xaml' because it does not exist.
Cannot find path 'C:\Projects\WindowsTemplateStudio\templates\Uwp\_composition\MVVMBasic\Feature.DeepLinking_Blank\Strings\en-us\Resources_postaction.resw' because it does not exist.
Cannot find path 'C:\Projects\WindowsTemplateStudio\templates\Uwp\_composition\MVVMBasic\Feature.DeepLinking_Blank\Views\SchemeActivationSamplePage_postaction.xaml' because it does not exist.
Cannot find path 'C:\Projects\WindowsTemplateStudio\templates\Uwp\_composition\MVVMBasic\Feature.DeepLinking_Blank\Views\SchemeActivationSamplePage_searchreplace.xaml' because it does not exist.
Cannot find path 'C:\Projects\WindowsTemplateStudio\templates\Uwp\_composition\MVVMLight\Feature.DeepLinking_Blank\Strings\en-us\Resources_postaction.resw' because it does not exist.
Cannot find path 'C:\Projects\WindowsTemplateStudio\templates\Uwp\_composition\MVVMLight\Feature.DeepLinking_Blank\Views\SchemeActivationSamplePage_postaction.xaml' because it does not exist.
Cannot find path 'C:\Projects\WindowsTemplateStudio\templates\Uwp\_composition\MVVMLight\Feature.DeepLinking_Blank\Views\SchemeActivationSamplePage_searchreplace.xaml' because it does not exist.
Cannot find path 'C:\Projects\WindowsTemplateStudio\templates\Uwp\_composition\_shared\Page.ContentGrid.Blank\Views\wts.ItemNameDetailPage_postaction.xaml' because it does not exist.
Cannot find path 'C:\Projects\WindowsTemplateStudio\templates\Uwp\_composition\_shared\Page.MasterDetail.Blank\Views\wts.ItemNamePage_postaction.xaml' because it does not exist.
Cannot find path 'C:\Projects\WindowsTemplateStudio\templates\Uwp\_composition\CodeBehind\Page.ContentGrid.Blank\.template.config\template.json' because it does not exist.
Cannot find path 'C:\Projects\WindowsTemplateStudio\templates\Uwp\_composition\CodeBehind\Page.ImageGallery.Blank\.template.config\template.json' because it does not exist.
Cannot find path 'C:\Projects\WindowsTemplateStudio\templates\Uwp\_composition\_shared\Page.ContentGrid.Blank\.template.config\template.json' because it does not exist.
Cannot find path 'C:\Projects\WindowsTemplateStudio\templates\Uwp\_composition\_shared\Page.MasterDetail.Blank\.template.config\template.json' because it does not exist.

I think it's failing because those files have been moved to the corresponding Blank.MenuBar composition template in C# and VB but not been deleted from the Blank composition template, could you doublecheck?

mrlacey commented 5 years ago

running tests to verify my fixes

mrlacey commented 5 years ago

Verified in Templates version: 0.20.19088.3 Wizard version: 0.20.19088.2