microsoft / TemplateStudio

Template Studio accelerates the creation of new WinUI 3, WPF, and UWP apps using a wizard-based experience.
Other
2.68k stars 457 forks source link

The foreground of App name always white No matter which theme #4630

Closed XiaoYQ-GitHub closed 1 year ago

XiaoYQ-GitHub commented 1 year ago

Describe the bug

The foreground of App name always white No matter which theme that selected in SettingsPage.

To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Additional context

No response

Applies to the following platforms:

About your setup

pratikone commented 1 year ago

Are you trying it on a new Project or it is an existing Template Studio project which you have updated to 5.3 ?

XiaoYQ-GitHub commented 1 year ago

I've done both. Please refer to the attachment for detail

从 Windows 版邮件https://go.microsoft.com/fwlink/?LinkId=550986发送

发件人: Pratik @.> 发送时间: 2023年2月17日 6:02 收件人: @.> 抄送: @.>; @.> 主题: Re: [microsoft/TemplateStudio] The foreground of App name always white No matter which theme (Issue #4630)

Are you trying it on a new Project or it is an existing Template Studio project which you have updated to 5.3 ?

― Reply to this email directly, view it on GitHubhttps://github.com/microsoft/TemplateStudio/issues/4630#issuecomment-1433776611, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQAI4EAQ5PCSBT5NHYZEOF3WX2PYJANCNFSM6AAAAAAU6AP5W4. You are receiving this because you authored the thread.Message ID: @.***>

Mysterious-Dev commented 1 year ago

I can confirm. image image

KiyanYang commented 1 year ago

same problem too.

like this https://github.com/microsoft/TemplateStudio/commit/c4b1b77b504a1ebafa780244906e4d547a16ef1f#diff-1824686b33499d8306e9941c5a34e1db685e824ea1881f0fcd0caa1e663ad93d , I add

<SolidColorBrush x:Key="WindowCaptionForeground" Color="{ThemeResource TextFillColorPrimary}" />
<SolidColorBrush x:Key="WindowCaptionForegroundDisabled" Color="{ThemeResource TextFillColorDisabled}" />

now can work

danvim commented 1 year ago

I think this might be the same problem as #4628. Just cross linking for future reference.

pratikone commented 1 year ago

this issue has been fixed by #4638 as well as #4666. Will be available in next release.