microsoft / TemplateStudio

Template Studio accelerates the creation of new WinUI 3, WPF, and UWP apps using a wizard-based experience.
Other
2.69k stars 459 forks source link

using community toolkit mvvm in viewmodel of webview #4639

Closed humbertomoli99 closed 1 year ago

humbertomoli99 commented 1 year ago

PR checklist

Quick summary of changes

Which issue does this PR relate to?

Applies to the following platforms:

Anything that requires particular review or attention?

Do all automated tests pass?

Have automated tests been added for new features?

If you've changed the UI:

If you've included a new template:

Have you raised issues for any needed follow-on work?

Have docs been updated?

If breaking changes or different ways of doing things have been introduced, have they been communicated widely?

mikebattista commented 1 year ago

Please sync with main which now has https://github.com/microsoft/TemplateStudio/issues/4640.

Also please resolve the below test failure.

At least one file (../../../../TemplateStudioForWinUICs/Templates\Pg\WebView\ViewModels\Param_ItemNameViewModel.cs) is not encoded correctly. Ensure all template files are encoded correctly with the script at '_utils/Set-All-Text-File-Template-Encodings.ps1'\r\nExpected: True\r\nActual:   False
mrlacey commented 1 year ago

@humbertomoli99 the changes you need to get this merged are at https://github.com/microsoft/TemplateStudio/compare/main...mrlacey:WindowsTemplateStudio:i4639-update?diff=split

image