search

microsoft / TemplateStudio

Template Studio accelerates the creation of new WinUI 3, WPF, and UWP apps using a wizard-based experience.
Other
2.65k stars 459 forks source link

Update to Windows App SDK 1.4.230913002 & WinUIEx 2.3.2 #4712

Closed Mysterious-Dev closed 7 months ago

Mysterious-Dev commented 10 months ago

PR checklist

Quick summary of changes

This PR update Windows App SDK to 1.4.230822000

Which issue does this PR relate to?

n/a

Applies to the following platforms:

All is in the title ^^.

https://www.nuget.org/packages/Microsoft.WindowsAppSDK/1.4.230822000

https://github.com/dotMorten/WinUIEx/releases/tag/v2.3

JasonWei512 commented 10 months ago

https://learn.microsoft.com/en-us/windows/apps/windows-app-sdk/stable-channel#known-issues In Windows App SDK 1.4, the min/max/close caption buttons for ExtendsContentIntoTitleBar = true are now drawn by AppWindow rather than XAML. TitlebarHelper needs to be updated, because now the titlebar color is set like this:

App.MainWindow.AppWindow.TitleBar.BackgroundColor = ...
App.MainWindow.AppWindow.TitleBar.ButtonHoverBackgroundColor = ...
Mysterious-Dev commented 9 months ago

Well, I've got the beginnings of a fix for that, I'll keep looking at it over the next few days to push the changes ^^.

Mysterious-Dev commented 9 months ago

@bpulliam @pratikone @mikebattista

Well, I think this PR is ready for review ^^

pratikone commented 8 months ago

Hi, thanks for the patience. For some time, I have been on-and-off investigating and working on this crash issue. https://github.com/microsoft/TemplateStudio/issues/4707

this is the reason, I am not been able to test this out this change because it could have ripple effects. Also my machine state is entirely broken because of that. Given it is a iterative change, I think it can wait. We anyways need the crash to be fixed before next version of Template Studio can get released

Mysterious-Dev commented 8 months ago

Hi, thanks for the patience. For some time, I have been on-and-off investigating and working on this crash issue. #4707

this is the reason, I am not been able to test this out this change because it could have ripple effects. Also my machine state is entirely broken because of that. Given it is a iterative change, I think it can wait. We anyways need the crash to be fixed before next version of Template Studio can get released

Well, now that #4707 is closed, I think we can get on with updating TemplateStudio for WASDK 1.4 ^^.

Mysterious-Dev commented 8 months ago

Thanks for the patience. I have reviewed this PR. Only minor changes are needed else it looks good. Once done, it can be merged and I will trigger newer version of template studio binary

@pratikone It's done, btw I also updated WinUIEx to 2.3.2 ^^.

pratikone commented 7 months ago

thanks for additional change. I have merged your PR. Will get a release binary out soon

Mysterious-Dev commented 7 months ago

thanks for additional change. I have merged your PR. Will get a release binary out soon

Glad to have helped (all tests passed btw) ^^.

pratikone commented 7 months ago

New version of Template Studio has been released.