tonymet commented 6 months ago

PR checklist

Quick summary of changes Fix .NET 8.0 specified RuntimeIdentifier 'win10-x64' is not recognized.

Full Error

NETSDK1083  The specified RuntimeIdentifier 'win10-x64' is not recognized. See https://aka.ms/netsdk1083 for more information.

More info: https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/8.0/runtimeidentifier

Steps to Repeat

Create new project from template
Build Project

Which issue does this PR relate to?

4717

Applies to the following platforms

[✅ ] WinUI
[ ] WPF
[ ] UWP

Anything that requires particular review or attention?

I could use help on how to perform e2e test with Template Studio using the updated template from this branch.
how to test this with earlier versions of .net e.g. .net 7 , .net 6
how to run automation on my own.

Do all automated tests pass?

✅ yes

Have automated tests been added for new features? N/A

If you've changed the UI: n/a

If you've included a new template: n/a

Have you raised issues for any needed follow-on work? n/a

Have docs been updated? no

If breaking changes or different ways of doing things have been introduced, have they been communicated widely?

licon4812 commented 6 months ago

I was able to get this working locally by adding this to my csproj

<UseRidGraph>true</UseRidGraph>
<RuntimeIdentifiers>win10-x86;win10-x64;win10-arm64</RuntimeIdentifiers>

pratikone commented 3 months ago

Thahks for this. @licon4812 is correct. I am planning to use true for maximum backward compatibility for the next release. You can close this PR or change to use Rid

tonymet commented 3 months ago

can you clarify? has it been fixed?