search

microsoft / TemplateStudio

Template Studio accelerates the creation of new WinUI 3, WPF, and UWP apps using a wizard-based experience.
Other
2.65k stars 459 forks source link

Hamburger button and page headers are not aligned #597

Closed sibille closed 7 years ago

sibille commented 7 years ago

image

image

crutkas commented 7 years ago

the entire header is off on this. look at the title

mrlacey commented 7 years ago

This and #612 highlight the need to do a full review of the generated pages. I thought I raised an issue on this when doing the Hamburger menu changes, as they don't all match the redlines, but can't find it now.

mrlacey commented 7 years ago

The images below are taken from the NavigationView control in the latest FCU SDK preview and do not have the spacing above and below the hamburger button that the original red-lines included.

(images based on this sample from the docs)

image image

@crutkas can you confirm that we should use this as a guideline over the red-lines and remove that space and therefore address the alignment issue that way?

crutkas commented 7 years ago

kill the whitespace.

mrlacey commented 7 years ago

Closing as verified in DevNightly

wizardVersion - 0.14.17192.65001 templatesVersion - 0.14.17192.4