Log Error if link is down (invalid speed)

microsoft / Test-NetHLK

Validates the default IHV Adapter settings according to the MSFT definitions and Switch Requirements for Azure Stack HCI

MIT License

5 stars 13 forks source link

Log Error if link is down (invalid speed) #8

Closed sandilyabhagi closed 2 years ago

sandilyabhagi commented 3 years ago

If the link is down (AdapterSpeed is 0/NULL) few variations like MaxRSSProcessors, NumRSSQueues and NicSwitch(*SRIOV) will fail due to $thisDefinitionPath resolved to NULL. The code assumes the previous parameter's definition and eventually validation fails.

Adding check for AdapterSpeed
Reinitializing $thisDefinitionPath inside switch.

dcuomo commented 2 years ago

Thank you @sandilyabhagi !!! This was very helpful. Apologies for the length of time that passed between you first opening this.

sandilyabhagi commented 2 years ago

@dcuomo, much obliged to contribute.