search

microsoft / TextWorld

​TextWorld is a sandbox learning environment for the training and evaluation of reinforcement learning (RL) agents on text-based games.
Other
1.23k stars 189 forks source link

Fix 163: Coin collector settings #165

Closed MarcCote closed 5 years ago

MarcCote commented 5 years ago

Currently, tw-make tw-coin_collector --level 100 is trying to generate a game with quest length of 0 (which is incorrect). This PR fixes #163.

tavianator commented 5 years ago

The test failure is:

ERROR: test_coin_collector.test_making_coin_collector
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/home/travis/build/microsoft/TextWorld/textworld/challenges/tests/test_coin_collector.py", line 23, in test_making_coin_collector
    game = make(settings, options)
  File "/home/travis/build/microsoft/TextWorld/textworld/challenges/coin_collector.py", line 72, in make
    options.grammar.allowed_variables_numbering = settings["force_entity_numbering"]
KeyError: 'force_entity_numbering'
MarcCote commented 5 years ago

Not sure if it is the right way for enforcing the --entity-numbering but that's clear to the user.

MarcCote commented 5 years ago

Fixed.