envs/glulx: Don't assume that closed tags will have been opened in the same action

microsoft / TextWorld

TextWorld is a sandbox learning environment for the training and evaluation of reinforcement learning (RL) agents on text-based games.

Other

1.23k stars 189 forks source link

envs/glulx: Don't assume that closed tags will have been opened in the same action #169

Closed tavianator closed 5 years ago

tavianator commented 5 years ago

This fixes #168.

MarcCote commented 5 years ago

Actually, we might want to detect Inform7 tags that span multiple turns :-/. For instance, issuing the restart command and answering yes, completely break the state tracking in GitGlulxML.

MarcCote commented 5 years ago

@tavianator if I remember correctly, we wanted to make a small change (i.e. only considering the ending Inform7 event tag) to this PR before merging it, right?

tavianator commented 5 years ago

@MarcCote Right, done