search

microsoft / TextWorld

​TextWorld is a sandbox learning environment for the training and evaluation of reinforcement learning (RL) agents on text-based games.
Other
1.23k stars 189 forks source link

Quest __eq_ method_ was not comparing commands. #199

Closed MarcCote closed 4 years ago

MarcCote commented 5 years ago

This PR fixes an issue with Quest objects comparison where the internal text commands were not properly compared.

This PR also makes sure that some of the Event and Quest attributes are tuples as expected.

This PR also changes the behavior of Game.copy. Now, copied Game.grammar objects will have their attribute .grammar set to None to avoid changing the entity names.

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b53b94d). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #199   +/-   ##
=========================================
  Coverage          ?   80.85%           
=========================================
  Files             ?       53           
  Lines             ?     6827           
  Branches          ?        0           
=========================================
  Hits              ?     5520           
  Misses            ?     1307           
  Partials          ?        0
Flag Coverage Δ
#unittests 80.85% <100%> (?)
Impacted Files Coverage Δ
textworld/generator/game.py 95.88% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b53b94d...960e112. Read the comment docs.