microsoft / TextWorld

TextWorld is a sandbox learning environment for the training and evaluation of reinforcement learning (RL) agents on text-based games.

Other

1.23k stars 189 forks source link

Prevent overwriting the name of matching entities (e.g. container-key). #237

Closed MarcCote closed 4 years ago

MarcCote commented 4 years ago

Closes issue #236

This PR prevents overwriting the name of already named entities even if those are "matching" entities (e.g. key <-> container, key <-> door).

codecov-commenter commented 4 years ago

Codecov Report

Merging #237 into master will decrease coverage by 0.00%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
- Coverage   82.85%   82.84%   -0.01%     
==========================================
  Files          56       56              
  Lines        6942     6944       +2     
==========================================
+ Hits         5752     5753       +1     
- Misses       1190     1191       +1

Impacted Files	Coverage Δ
textworld/generator/text_generation.py	`84.23% <50.00%> (-0.19%)`	:arrow_down: