search

microsoft / TransformerCompression

For releasing code related to compression methods for transformers, accompanying our publications
MIT License
354 stars 31 forks source link

Update transformers to 4.41.0 #150

Closed pashminacameron closed 3 months ago

msdmkats commented 3 months ago

I really don't like the idea of having a dependency on the latest commit in some repository (as opposed to depending on a specific commit). The latest commit is subject to unannounced and not necessarily intentional breaking changes, which can break our experiments without any changes on our side. This did happen before, with lm-eval, if my memory serves me correctly.

pashminacameron commented 3 months ago

I really don't like the idea of having a dependency on the latest commit in some repository (as opposed to depending on a specific commit). The latest commit is subject to unannounced and not necessarily intentional breaking changes, which can break our experiments without any changes on our side. This did happen before, with lm-eval, if my memory serves me correctly.

Yes, let's point to the bug-fix commit and then there is going to be a release soon, at which point we can point to the release. Happy to even wait until the release.

pashminacameron commented 3 months ago

I really don't like the idea of having a dependency on the latest commit in some repository (as opposed to depending on a specific commit). The latest commit is subject to unannounced and not necessarily intentional breaking changes, which can break our experiments without any changes on our side. This did happen before, with lm-eval, if my memory serves me correctly.

Yes, let's point to the bug-fix commit and then there is going to be a release soon, at which point we can point to the release. Happy to even wait until the release.

New release is out!