microsoft / TypeScript-DOM-lib-generator

Tool for generating dom related TypeScript and JavaScript library files
Apache License 2.0
601 stars 418 forks source link

fix: add icecandidateerror type #1661

Closed ntsd closed 7 months ago

ntsd commented 7 months ago

Reference: https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/icecandidateerror_event

github-actions[bot] commented 7 months ago

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

ntsd commented 7 months ago

@ntsd please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

saschanaz commented 7 months ago

Included in #1660, but LGTM anyway.

github-actions[bot] commented 7 months ago

Merging because @saschanaz is a code-owner of all the changes - thanks!