Closed thkruz closed 9 months ago
Thanks for the PR!
This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.
@microsoft-github-policy-service agree
Yeah, it has been there forever since 2015:
Perhaps it was somewhere from MSDN?
LGTM
Merging because @saschanaz is a code-owner of all the changes - thanks!
Yeah, it has been there forever since 2015:
Haha yea when I saw that I assumed I was wrong since no one else has fixed it.
Perhaps it was somewhere from MSDN?
I couldn't find it on google, but who knows what i might have found back then.
Regardless, glad to help. Thanks.
Fairly simple one. Since there is no return value, the paused property should be used for testing if a media element is paused instead of the pause method.
Looking at the spec
That comment has been there 6 years, so I am not sure of the origin, but it confused me so I made the PR.
References: https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/pause https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/paused