search

microsoft / TypeScript-DOM-lib-generator

Tool for generating dom related TypeScript and JavaScript library files
Apache License 2.0
600 stars 417 forks source link

NotificationOptions is missing actions option #1725

Open TheNoim opened 1 month ago

TheNoim commented 1 month ago

Hey,

I noticed that the NotificationOptions definition doesn't include the actions option. This is the current definition: dom.generated.d.ts and serviceworker.generated.d.ts

Here is the relevant mdn link.

In addition, timestamp and renotify are also missing.

This might be an regression of #438, but I am not sure.

HolgerJeromin commented 1 month ago

https://github.com/microsoft/TypeScript-DOM-lib-generator?tab=readme-ov-file#when-the-type-is-missing

If there is, see the browser compatibility section and check whether it's supported by two or more browser engines. (Note that Chromium-based browsers use the same browser engine and thus support from them counts as a single support.)

So your suggestion is missing Firefox or Safari support.

benelliott commented 1 month ago

As mentioned by @TheNoim, timestamp has been removed without any documentation on MDN suggesting lack of support.

markusahrweileramcon commented 1 week ago

So your suggestion is missing Firefox or Safari support.

requireInteraction ist included and has the same support as actions