Closed rjimenezda closed 1 week ago
Thanks for the PR!
This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.
Good job @rjimenezda LGTM!
Sorry @chemitaxis, you don't have access to these files:
@microsoft-github-policy-service agree company="Genially"
As stated in #1486 I'd rather not do this only for this specific API. We could make any not-supported-everywhere things as optional but such breaking change needs agreement from TS team. Discussion can go on in #1486.
Fair enough, I'll close it then.
Hi!
I've recently worked with
navigator.share
andnavigator.canShare
and have noticed that the types report them as non-optional.I saw #837 where it's stated that the w3c says they are non-optional, but the truth is that most desktop browsers do not implement them and are only supported on secure contexts, so they can be undefined in certain cases.
I'm not sure if there's something else that should be changed, let me know.