microsoft / TypeScript-DOM-lib-generator

Tool for generating dom related TypeScript and JavaScript library files
Apache License 2.0
622 stars 421 forks source link

fix: `DedicatedWorkerGlobalScope.close()` and `SharedWorkerGlobalScope.close()` return type - `never` #1806

Closed turansky closed 2 months ago

turansky commented 2 months ago
github-actions[bot] commented 2 months ago

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

turansky commented 2 months ago

@microsoft-github-policy-service agree

saschanaz commented 2 months ago

This is not necessarily true:

new Worker(URL.createObjectURL(new Blob([`
  self.close();
  console.log("closed?");
`])))

// You can see "closed?" on devtools console
turansky commented 2 months ago

@saschanaz thank you for example