microsoft / TypeScript-Handbook

Deprecated, please use the TypeScript-Website repo instead
https://github.com/microsoft/TypeScript-Website
Apache License 2.0
4.88k stars 1.13k forks source link

TS 3.7 Release Notes Nullish Coalescing example wrong #1135

Open Cristy94 opened 4 years ago

Cristy94 commented 4 years ago

https://github.com/microsoft/TypeScript-Handbook/blob/master/pages/release%20notes/TypeScript%203.7.md#nullish-coalescing

I know this was only given as an example, but there's a small mistake:

Screenshot:

image

What is wrong?

It says that let volume = localStorage.volume || 0.5 will be 0.5 when localStorage.volume is set to 0, but everything stored in localStorage can only be a string and "0" is truthy.

localStorage.volume = 0; // saved as "0"
let volume = localStorage.volume || 0.5;  // volume = "0" || 0.5
volume === "0" // Not 0.5 as mentioned in the example