search

microsoft / TypeScript-Handbook

Deprecated, please use the TypeScript-Website repo instead
https://github.com/microsoft/TypeScript-Website
Apache License 2.0
4.88k stars 1.13k forks source link

update for gulp-typescript handbook example #355

Open DanielRosenwasser opened 8 years ago

DanielRosenwasser commented 8 years ago

From @Mimieam on July 30, 2016 16:9

TypeScript Version: 1.8.0

Code I believe the tsconfig.json file in TS + Gulp handbook example need to be updated with 

     "exclude": [
        "node_modules"
    ]

Expected behavior: no errors Actual behavior: The last example with browserify returns this:

TypeScript error: node_modules/bs-recipes/recipes/webpack.typescript.react/src/components/HelloWorld.tsx(12,13): 
Error TS17004: Cannot use JSX unless the '--jsx' flag is provided.

Copied from original issue: Microsoft/TypeScript#10047

DanielRosenwasser commented 8 years ago

Weird, why is that package there and why does it have ts?

In any case, yes, for 2.0 we should just update everything to use include.