microsoft / TypeScript-Node-Starter

A reference example for TypeScript and Node with a detailed README describing how to use the two together.
MIT License
11.31k stars 2.77k forks source link

Migrate TSLint to ESLint. Closes #209 #211

Closed peterblazejewicz closed 5 years ago

peterblazejewicz commented 5 years ago

This commit rewrites linting support in the project to be based solely on the ESLint as advised by the TSLint tool authors: https://medium.com/palantir/tslint-in-2019-1a144c2317a9

The migration is based on default, recommended settings for TypeScript in ESLint and is expected to be updated in future to better fit project goals.

All references has been updated and replaced with relevant ESLint context:

This is the output of the npm run lint script:

npm run lint

> express-typescript-starter@0.1.0 lint /Users/piotrblazejewicz/git/TypeScript-Node-Starter
> tsc --noEmit && eslint '*/**/*.{js,ts}' --quiet --fix

Thanks!

/cc @felipesilvati

orta commented 5 years ago

Looks like tests are after including an @types dep?

peterblazejewicz commented 5 years ago

Looks like tests are after including an @types dep?

Yup, thanks! Interesting it worked locally. The PR updated. Let's wait for Travis

orta commented 5 years ago

Cool, nice, ship it when you're happy 👍