Closed GrayStrider closed 5 years ago
Just figuring out how everything works, sorry if it's rough around the edges Oh wow, build passed! yay 🎉
Can a ask for a bit of advice, please: what if I want to push to my fork branch, but don't want to include these commits to this pull request? Or I should just wait for this PR to be closed and in the meantime use a different branch? I'll revert the last commit if needed, and perhaps submit it separetely, but it's kinda based on the previous ones partially. What do?
you could work on this branch as long as you want. It seems you have started directly from your local master
branch. Usually people should create a topic branch to work with, but even in the GitHub docs using master
fork branch is being used:
https://github.com/collections/choosing-projects
Your changes can be later squashed into a single commit if accepted, so usually that does not matter how many changes you push to your PR
you could create new local topic branch on work on the other changes as you want and use that new branch as base for your PR against this repo (this doc does not use master, it explain why to not user master in forks): https://help.github.com/en/articles/creating-a-pull-request Using new topic branch is preferable for variety of different reasons.
Up to you, you've even used very new draft
feature to make this PR:
https://github.blog/2019-02-14-introducing-draft-pull-requests/
created new PR from separate branch #232
Consolidate repeating types, augment express.Request with User model (copies #227 ) Update User model: https://github.com/microsoft/TypeScript-Node-Starter/blob/1409fd7164e4320d809094ae7d338680e14fc1cd/src/controllers/user.ts#L217 seem to be unused, otherwise need to introduce indexing field to UserDocument