microsoft / TypeScript-Node-Starter

A reference example for TypeScript and Node with a detailed README describing how to use the two together.
MIT License
11.31k stars 2.77k forks source link

Update "any" types to more precise #230

Closed GrayStrider closed 5 years ago

GrayStrider commented 5 years ago

Consolidate repeating types, augment express.Request with User model (copies #227 ) Update User model: https://github.com/microsoft/TypeScript-Node-Starter/blob/1409fd7164e4320d809094ae7d338680e14fc1cd/src/controllers/user.ts#L217 seem to be unused, otherwise need to introduce indexing field to UserDocument

msftclas commented 5 years ago

CLA assistant check
All CLA requirements met.

GrayStrider commented 5 years ago

Just figuring out how everything works, sorry if it's rough around the edges Oh wow, build passed! yay 🎉

GrayStrider commented 5 years ago

Can a ask for a bit of advice, please: what if I want to push to my fork branch, but don't want to include these commits to this pull request? Or I should just wait for this PR to be closed and in the meantime use a different branch? I'll revert the last commit if needed, and perhaps submit it separetely, but it's kinda based on the previous ones partially. What do?

peterblazejewicz commented 5 years ago

Up to you, you've even used very new draft feature to make this PR: https://github.blog/2019-02-14-introducing-draft-pull-requests/

GrayStrider commented 5 years ago

created new PR from separate branch #232