search

microsoft / TypeScript-Node-Starter

A reference example for TypeScript and Node with a detailed README describing how to use the two together.
MIT License
11.31k stars 2.77k forks source link

Move to bcrypt from bcrypt-nodejs #244

Open davl3232 opened 4 years ago

davl3232 commented 4 years ago

This project uses bcrypt-nodejs library for hashing and salting user passwords. That library seems very outdated, to the point there's a notice on its NPM page.

Now there's bcrypt that supports both promises and callbacks. It also looks well maintained and has typescript types available.

Can it be changed? Or is there a reason for using bcrypt-nodejs?

peterblazejewicz commented 4 years ago

Hi, It was obviously missed in the output of the default install. The NPM outdated does not report this, so it was probably just overlooked. Yes, could be done, prefferably in the default, async version (no promises), to keep in sync with other existing code. I'd help you with a PR if you would like to do one, Thanks!

davl3232 commented 4 years ago

Hey Peter, I just submitted #245 with this change. Thank you.