Added GitHub Actions CI Workflow

microsoft / TypeScript-Node-Starter

A reference example for TypeScript and Node with a detailed README describing how to use the two together.

MIT License

11.3k stars 2.76k forks source link

Added GitHub Actions CI Workflow #261

Closed bmiddha closed 4 years ago

bmiddha commented 4 years ago

Added a GitHub Actions Workflow with a matrix strategy for Node.js 8.x, 10.x, and 12.x and across Ubuntu, MacOS, and Windows with support for node_modules caching to improve speed.

orta commented 4 years ago

I'm happy with this 👍

My opinion is that it might not need to be so comprehensive (testing on Mac/window/linux) across 2 node versions? Worth bringing it down to just linux?

peterblazejewicz commented 4 years ago

Worth bringing it down to just linux? And just lastest Node LTS (12)

orta commented 4 years ago

haha, guess we're in alignment then :D

bmiddha commented 4 years ago

I wanted to add an OS build matrix to make sure the contributors get alerted by build fails if they attempt to do some OS specific commands in their code / config files. (for example using rm or del in the scripts section of package.json to clean built files.) Should I continue to remove it? Also, should I remove the travis.yml or keep both Travis CI and GitHub Actions for CI testing? @orta @peterblazejewicz

orta commented 4 years ago

Yep 👍