search

microsoft / TypeScript-Node-Starter

A reference example for TypeScript and Node with a detailed README describing how to use the two together.
MIT License
11.3k stars 2.76k forks source link

Migrate from `bcrypt-nodejs` to `bcrypt` #283

Closed ghost closed 4 years ago

ghost commented 4 years ago

Closes #44

msftclas commented 4 years ago

CLA assistant check
All CLA requirements met.

ghost commented 4 years ago

Added commits in reference to #285.

peterblazejewicz commented 4 years ago

These are three different topics here: 1) chai - seems no brainer, it seems to be left-over from previous implementation detail 2) bcrypt - this was already discussed on project and raised. In all previous occasions PR owners decided to not update the library, as the bcrypt rquires native dependencies that are not always available for specific installation. E.g. see comment: https://github.com/microsoft/TypeScript-Node-Starter/pull/253#issuecomment-564441456 3) model definition - that's not brainer either, OK.

If you could split this PR into focused ones, it would be better to grasp the topics. (make three branches, cherry-pick your commits to topic branch, push pr), it would help

bluepuma77 commented 4 years ago

I tested TypeScript-Node-Starter for the first time today and stumbled upon this:

npm WARN deprecated bcrypt-nodejs@0.0.3: bcrypt-nodejs is no longer actively maintained. Please use bcrypt or bcryptjs. See https://github.com/kelektiv/node.bcrypt.js/wiki/bcrypt-vs-brypt.js to learn more about these two options

For newcomers it might look like your project is not maintained when using deprecated libraries.